Repository navigation
Conversation
beutlich
force-pushed
the
EvaluateTableOnFile
branch
from
October 20, 2026 20:57
36f2375 to
93fd631
Compare
beutlich
requested changes
Oct 20, 2026
beutlich
left a comment
beutlich
left a comment
Member
There was a problem hiding this comment.
Inconsistent with CombiTimeTable.
Contributor
Author
|
If this change is even desired, I can of course also add it to CombiTimeTable |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest to evaluate the parameter Boolean tableOnFile, assuming that it will typically not be changed between two simulations, and evaluating it will slightly simplify the generate code.
If that is a common/useful workflow, then the PR should be rejected of course.